Skip to content

fix: Use try-catch to handle winget uninstall errors #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hustcer merged 2 commits into from
Feb 4, 2026
Merged

fix: Use try-catch to handle winget uninstall errors #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7eeba23
fix: Use try-catch to handle winget uninstall errors
hustcer Feb 4, 2026
1e04689
fix: Use GITHUB_TOKEN for API requests to avoid rate limiting
hustcer Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion tests/common.nu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,12 @@ export def check-version-match [version_expected: string, install_dir = $USER_IN
}

export def get-latest-tag [] {
http get https://api.github.com/repos/nushell/nightly/releases
let headers = if ($env.GITHUB_TOKEN? | is-not-empty) {
{ Authorization: $'Bearer ($env.GITHUB_TOKEN)' }
} else {
{}
}
http get -H $headers https://api.github.com/repos/nushell/nightly/releases
| sort-by -r created_at
| where tag_name =~ nightly
| get tag_name?.0?
Expand Down
8 changes: 4 additions & 4 deletions tests/test-all.nu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def main [--msi(-m), --local] {
}

export def test-msi-per-user-install [] {
winget uninstall nushell | complete
try { winget uninstall nushell } catch { }
print $'Using msiexec to test MSI (ansi g)per-user(ansi reset) installation'
print '-------------------------------------------------------------------'
msiexec /i $MSI_PKG MSIINSTALLPERUSER=1 /quiet /qn /L*V install.txt
Expand All @@ -43,7 +43,7 @@ export def test-msi-per-user-install [] {
}

export def test-msi-per-machine-install [] {
winget uninstall nushell | complete
try { winget uninstall nushell } catch { }
print $'(char nl)Using msiexec to test MSI (ansi g)machine scope(ansi reset) installation'
print '-------------------------------------------------------------------'
msiexec /i $MSI_PKG ALLUSERS=1 /L*V install.txt
Expand All @@ -53,7 +53,7 @@ export def test-msi-per-machine-install [] {
}

export def test-winget-per-user-install [--local] {
winget uninstall nushell | complete
try { winget uninstall nushell } catch { }
print $'(char nl)Using winget to test MSI (ansi g)user scope(ansi reset) installation'
print '-------------------------------------------------------------------'
if $local {
Expand Down Expand Up @@ -83,7 +83,7 @@ export def test-winget-per-user-upgrade [--local] {
}

export def test-winget-per-machine-install [--local] {
winget uninstall nushell | complete
try { winget uninstall nushell } catch { }
print $'(char nl)Using winget to test MSI (ansi g)machine scope(ansi reset) installation'
print '-------------------------------------------------------------------'
if $local {
Expand Down
7 changes: 6 additions & 1 deletion tests/winget-install.nu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,12 @@ export def prepare-manifest [] {
}

def get-download-url [] {
http get https://api.github.com/repos/nushell/nightly/releases
let headers = if ($env.GITHUB_TOKEN? | is-not-empty) {
{ Authorization: $'Bearer ($env.GITHUB_TOKEN)' }
} else {
{}
}
http get -H $headers https://api.github.com/repos/nushell/nightly/releases
| sort-by -r created_at
| where tag_name =~ nightly | get assets.0.browser_download_url
| where $it =~ 'msi'
Expand Down