Skip to content

Fix build breakage from prism-go-client v0.5.5 → v0.7.1 upgrade#188

Merged
tuxtof merged 1 commit intomasterfrom
copilot/check-fix-issue-from-pr-167
Apr 14, 2026
Merged

Fix build breakage from prism-go-client v0.5.5 → v0.7.1 upgrade#188
tuxtof merged 1 commit intomasterfrom
copilot/check-fix-issue-from-pr-167

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 13, 2026

Summary

PR #167 (Dependabot bump of prism-go-client v0.5.5 → v0.7.1 and logrus v1.9.3 → v1.9.4) was blocked because prism-go-client v0.6.0 changed ClusterSpec.Name and ClusterStatus.Name from *string to string. The driver code was still dereferencing these as pointers, causing compilation failures:

machine/driver/driver.go:178:7: invalid operation: cannot indirect peSpec.Name (variable of type string)
machine/driver/driver.go:189:47: invalid operation: cannot indirect foundClusters[0].Status.Name (variable of type string)

Changes

  • go.mod / go.sum: Bump prism-go-client v0.5.5 → v0.7.1, logrus v1.9.3 → v1.9.4, and associated transitive dependency updates (go-logr/logr, google/go-cmp, protobuf, stretchr/testify, k8s.io/utils)
  • machine/driver/driver.go: Remove invalid pointer dereferences on now-value-typed Name fields
// Before
if *peSpec.Name == d.Cluster { ... }
log.Infof("Cluster %s found with UUID: %s", *foundClusters[0].Status.Name, ...)

// After
if peSpec.Name == d.Cluster { ... }
log.Infof("Cluster %s found with UUID: %s", foundClusters[0].Status.Name, ...)

Fixes the CI failures reported in #167.

…nd fix string dereferences

Agent-Logs-Url: https://github.com/nutanix/docker-machine/sessions/604bd5ff-b5f7-45d0-b2b1-5caf31eaff74

Co-authored-by: tuxtof <180613+tuxtof@users.noreply.github.com>
@tuxtof tuxtof marked this pull request as ready for review April 13, 2026 21:23
@tuxtof tuxtof requested a review from wolfganghuse April 13, 2026 21:24
Copy link
Copy Markdown
Collaborator

@wolfganghuse wolfganghuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tuxtof tuxtof merged commit 470f21a into master Apr 14, 2026
9 checks passed
@tuxtof tuxtof deleted the copilot/check-fix-issue-from-pr-167 branch April 14, 2026 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants