Fix broken assertions in RadarPointCloud PCD header parsing#1191
Open
Mr-Neutr0n wants to merge 1 commit intonutonomy:masterfrom
Open
Fix broken assertions in RadarPointCloud PCD header parsing#1191Mr-Neutr0n wants to merge 1 commit intonutonomy:masterfrom
Mr-Neutr0n wants to merge 1 commit intonutonomy:masterfrom
Conversation
- Fix height assertion error message: said "height != 0" but the check is "height == 1", so the message now correctly says "height != 1". - Fix COUNT assertion: the expression `c != c` is always False for strings, making the assertion a no-op. Replace with an explicit check that all COUNT values equal 1, since multi-element fields are not supported by the binary parser below.
Collaborator
|
Lgtm, thanks for raising this @Mr-Neutr0n! |
whyekit-motional
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two bugs in
RadarPointCloud.from_file()PCD header validation (python-sdk/nuscenes/utils/data_classes.py):Height assertion error message: The check is
assert height == 1but the error message said"height != 0 not supported!". Fixed to say"height != 1 not supported!".COUNT assertion is a no-op: The expression
c != cis alwaysFalsefor strings (theNaN != NaNtrick only works on floats), soassert len([c for c in counts if c != c]) == 0always passes regardless of the COUNT values. Replaced withassert all(int(c) == 1 for c in counts)to properly enforce that multi-element fields are not supported by the binary parser.Test plan