test(nitro): stop sharing build state between the module and e2e suites - #329
Merged
Conversation
`module.test.ts` drove the `types:extend` hook against the shared discovery fixture, then removed `node_modules/.nitro` from it in `afterAll`. The e2e suite builds that same fixture out of the same directory, so the cleanup could land mid-build and fail it — roughly one run in four once the module suite grew long enough to overlap. The hook test now runs against its own temporary app, which leaves nothing for the fixture to share.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
2 tasks
Contributor
|
Thank you for following the naming conventions! 🙏 |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Description
Base of a six-PR stack splitting the OAuth, plugins and scopes work. Nothing here is user-facing, so no changeset.
module.test.tsdrove thetypes:extendhook against the shared discovery fixture, then removednode_modules/.nitrofrom it inafterAll. The e2e suite builds that same fixture out of the same directory, so the cleanup could land mid-build and fail it — roughly one run in four once the module suite grew long enough to overlap.The hook test now runs against its own temporary app, which leaves nothing for the fixture to share. Verified by running the package suite five times in a row: 151 passing each time.
📝 Checklist