fix(dev): serve the error channel to remote peers, scoped - #1554
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
commit: |
CLI benchmark
Full report
|
| Setting | Value |
|---|---|
| Baseline | ref:ef6a852102a7035ec10e4daa178e5df811a216e0 (v4.0.0-alpha.1) |
| Head | local packages/nuxt-cli at 8de67fb (v4.0.0-alpha.1) |
| Node | v24.21.0 |
| OS | Linux 6.17.0 (kernel 6.17.0-1022-azure) |
| CPU | AMD EPYC 9V74 80-Core Processor x 4 |
| Memory | 15.6 GB |
| Load average at start | 1.03, 0.29, 0.10 |
| Run started | 2026-09-22T10:13:43.173Z |
Cold CLI startup
Median of 15 interleaved runs per command, one warmup discarded.
| Command | baseline v4.0.0-alpha.1 median | head v4.0.0-alpha.1 median | Delta | baseline v4.0.0-alpha.1 min / p95 | head v4.0.0-alpha.1 min / p95 |
|---|---|---|---|---|---|
nuxt --version |
69 ms | 69 ms | +0.0% | 67 ms / 73 ms | 68 ms / 71 ms |
nuxt --version (first output byte) |
64 ms | 64 ms | +0.0% | 62 ms / 68 ms | 63 ms / 66 ms |
nuxt --help |
147 ms | 146 ms | -0.3% | 144 ms / 150 ms | 143 ms / 149 ms |
nuxt --help (first output byte) |
141 ms | 140 ms | -0.4% | 139 ms / 144 ms | 137 ms / 143 ms |
nuxt dev --help |
113 ms | 112 ms | -0.9% | 110 ms / 116 ms | 109 ms / 116 ms |
nuxt dev --help (first output byte) |
107 ms | 107 ms | -0.6% | 104 ms / 111 ms | 103 ms / 111 ms |
nuxt <unknown-command> (no-op) |
157 ms | 157 ms | -0.0% | 153 ms / 160 ms | 152 ms / 159 ms |
nuxt <unknown-command> (no-op) (first output byte) |
151 ms | 150 ms | -0.5% | 148 ms / 154 ms | 146 ms / 153 ms |
Module load cost
Counted with a module.registerHooks load hook, compile cache disabled. Counts every JS module actually evaluated on that code path (built-ins excluded, native addons excluded).
| Command | baseline v4.0.0-alpha.1 modules | head v4.0.0-alpha.1 modules | Delta | baseline v4.0.0-alpha.1 source bytes | head v4.0.0-alpha.1 source bytes | Delta |
|---|---|---|---|---|---|---|
nuxt --version |
37 | 37 | 0.0% | 302.8 kB | 302.8 kB | 0.0% |
nuxt --help |
139 | 139 | 0.0% | 1.03 MB | 1.03 MB | -0.1% |
nuxt dev --help |
82 | 82 | 0.0% | 645.9 kB | 645.3 kB | -0.1% |
Install footprint and published tarball
Each version installed on its own into an empty project with nothing but @nuxt/cli as a dependency, so the tree is exactly the CLI and its transitive dependencies. npm cache is warm and the registry is only consulted for metadata, so install wall time is indicative, not a network benchmark.
| Metric | baseline v4.0.0-alpha.1 | head v4.0.0-alpha.1 | Delta |
|---|---|---|---|
Direct dependencies of @nuxt/cli |
22 | 22 | 0.0% |
| Packages in the installed tree (unique name@version) | 38 | 38 | 0.0% |
| Unique package names | 38 | 38 | 0.0% |
| Package directories on disk (cross-check) | 31 | 31 | 0.0% |
Installed node_modules on disk |
2.38 MB | 2.38 MB | -0.0% |
| Installed files | 407 | 407 | 0.0% |
| Install wall time (warm npm cache, median of 3) | 1.29 s | 1.29 s | -0.2% |
| Published tarball (packed) | 232.0 kB | 231.6 kB | -0.1% |
| Published tarball (unpacked) | 757.3 kB | 756.7 kB | -0.1% |
| Files in tarball | 84 | 84 | 0.0% |
Interleaved runs on a shared runner: trust the deltas, not the absolute timings. The dev, restart and build suites run locally via pnpm bench:cli.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe error channel now accepts remote requests and passes a Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to Remote peers receive scoped error-channel access while loopback peers retain privileged access; no concrete merge-blocking risk is established. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔗 Linked issue
📚 Description
implements danielroe/my-bad#46