Skip to content

chore: agent metadata helper, MCP server-card listings, light-mode fix#2240

Merged
atinux merged 3 commits intomainfrom
chore/agent-mcp-cleanup
May 5, 2026
Merged

chore: agent metadata helper, MCP server-card listings, light-mode fix#2240
atinux merged 3 commits intomainfrom
chore/agent-mcp-cleanup

Conversation

@HugoRCD
Copy link
Copy Markdown
Member

@HugoRCD HugoRCD commented May 5, 2026

CleanShot 2026-05-05 at 10 03 27@2x CleanShot 2026-05-05 at 10 03 29@2x

@HugoRCD HugoRCD self-assigned this May 5, 2026
@HugoRCD HugoRCD requested a review from atinux as a code owner May 5, 2026 08:57
@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nuxt Ready Ready Preview, Comment May 5, 2026 10:11am

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 5, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8d2946fa-fc14-4f57-94dc-4d7f3e1bbaf1

📥 Commits

Reviewing files that changed from the base of the PR and between 7dc648e and d45730d.

📒 Files selected for processing (1)
  • server/api/agent.post.ts

📝 Walkthrough

Walkthrough

AgentShader.vue: theme-aware computed values added (colorMode, isDark) and dotSize/dotColor updated; DotGrid now binds :color="dotColor". server/api/agent.post.ts: removed computeEstimatedCost and now reads model, provider, inputTokens, outputTokens, estimatedCost, and durationMs from ai.getMetadata(). server/routes/.well-known/mcp/server-card.json.get.ts: handler made async, now awaits listMcpDefinitions(), filters out items with group === 'admin', and maps tools/resources/prompts into the server card dynamically; response and caching behavior unchanged.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ⚠️ Warning The PR description consists only of two screenshots without any text explanation, making it impossible to understand the changeset intent. Add a detailed text description explaining the changes, why they were made, and how they address the PR objectives (agent metadata helper, MCP server-card listings, and light-mode fix).
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the three main changes: agent metadata helper, MCP server-card listings, and light-mode fix.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/agent-mcp-cleanup

Warning

Review ran into problems

🔥 Problems

Timed out fetching pipeline failures after 30000ms

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (2)
app/components/agent/AgentShader.vue (2)

2-2: 💤 Low value

import { computed } from 'vue' is redundant

Framework functions like computed will still work without needing manual imports in Nuxt. useColorMode() is likewise auto-imported from @nuxtjs/color-mode. The explicit import on line 2 can be dropped to stay consistent with the rest of the file.

♻️ Proposed cleanup
-import { computed } from 'vue'
 import { Shader, DotGrid, ImageTexture } from 'shaders/vue'
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@app/components/agent/AgentShader.vue` at line 2, The explicit import "import
{ computed } from 'vue'" in AgentShader.vue is redundant; remove that import
line and rely on Nuxt's auto-imported runtime helpers (e.g., computed and
useColorMode) so the rest of the file (references to computed and useColorMode)
continues to work without the manual import.

13-15: 💤 Low value

Remove redundant computed import

In Nuxt 4 with auto-imports, both computed and useColorMode are automatically available without explicit imports. Line 2's import { computed } from 'vue' can be removed.

♻️ Cleanup
-import { computed } from 'vue'
 import { Shader, DotGrid, ImageTexture } from 'shaders/vue'

The rest of the implementation is correct—useColorMode().value properly resolves the color mode, and the isDark, dotSize, and dotColor computed properties are all properly configured.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@app/components/agent/AgentShader.vue` around lines 13 - 15, Remove the
redundant import of computed from 'vue' in AgentShader.vue: since Nuxt 4
auto-imports both computed and useColorMode, delete the explicit `import {
computed } from 'vue'` so the file only relies on auto-imports; ensure
references to computed in the file (e.g., isHero, isDark) continue to work and
no other unused imports remain.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@server/api/agent.post.ts`:
- Around line 138-140: The metadata extraction uses possibly undefined token
fields which will break later SQL aggregations; change the destructuring to
provide null-safe defaults by replacing direct reads with nullish coalescing
(e.g., use metadata.inputTokens ?? 0 and metadata.outputTokens ?? 0) while
keeping the existing estimatedCost and totalDurationMs defaults (estimatedCost
?? 0, totalDurationMs ?? 0) so all numeric values are guaranteed numbers before
aggregation.

---

Nitpick comments:
In `@app/components/agent/AgentShader.vue`:
- Line 2: The explicit import "import { computed } from 'vue'" in
AgentShader.vue is redundant; remove that import line and rely on Nuxt's
auto-imported runtime helpers (e.g., computed and useColorMode) so the rest of
the file (references to computed and useColorMode) continues to work without the
manual import.
- Around line 13-15: Remove the redundant import of computed from 'vue' in
AgentShader.vue: since Nuxt 4 auto-imports both computed and useColorMode,
delete the explicit `import { computed } from 'vue'` so the file only relies on
auto-imports; ensure references to computed in the file (e.g., isHero, isDark)
continue to work and no other unused imports remain.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7f4984f2-134e-44f8-929e-fd82ab9527b3

📥 Commits

Reviewing files that changed from the base of the PR and between 8d67c60 and 7dc648e.

📒 Files selected for processing (3)
  • app/components/agent/AgentShader.vue
  • server/api/agent.post.ts
  • server/routes/.well-known/mcp/server-card.json.get.ts

Comment thread server/api/agent.post.ts Outdated
atinux and others added 2 commits May 5, 2026 11:28
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@atinux atinux merged commit 5c9ac61 into main May 5, 2026
8 of 10 checks passed
@atinux atinux deleted the chore/agent-mcp-cleanup branch May 5, 2026 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants