chore(pulse-analytics): use an inline SVG logo instead of a PNG URL - #923
Conversation
The entry shipped a URL to a 64px PNG. It is one of only three URL-based logos in the registry and the only raster one, so it renders soft on any retina card while every neighbour stays crisp. Replaced with the vector mark, inline like the other 37. Sized against the peers: 1,369 bytes, rank 10 of 38, median 805.
|
@uz1mani is attempting to deploy a commit to the Nuxt Team on Vercel. A member of the Team first needs to authorize it. |
🤖 REVIEW PAUSED
This pull request is from an outside contributor. Add the |
|
Understand this PR’s impact Explore downstream dependencies and potential security impact with Blast Radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Worth linking: this logo will not be visible on scripts.nuxt.com until the site picks up a build past The same staleness is why So this PR is correct on its own terms and testable via the unit test, but the visible result depends on #924. |
commit: |
📦 Package Size📚 22 runtime dependencies (no change)
All tracked output (25)
Runtime dependencies (22)
Baseline: main_@_e711225b___2026-09-17 · gzip is the comparison metric · changes below 16 B gzip are ignored |
|
Thanks :) |
The
pulseAnalyticsentry shipped a URL to a 64px PNG. Swapped for the vector mark, inline like the other 37 logos.One file, one line:
packages/script/src/registry-logos.ts.Why
clarityandtawkToare the other two URLs).Size
1,369 bytes — rank 10 of 38 inline logos, against a median of 805.
The source was an auto-trace at 5,839 bytes, which would have been rank 2.
svgo --precision=1cut it 77%; a pixel diff of before against after shows differences confined to edge antialiasing, with no geometry moved.The mark also gained a
viewBoxit did not have — the source declaredwidth/heightonly, so it could not scale inline. Measured ink bounds werex 32.8..163.5, y -0.7..192.6; the viewBox is that squared.Test
test/unit/registry-logos.test.ts— 2 passed, no type errors.Control: replacing the value with a
data:image/png;base64,…string fails it withpulseAnalytics logo should be SVG or image URL, so the pass is meaningful.