-
Notifications
You must be signed in to change notification settings - Fork 116
fix(config): tolerate non-cloneable values when cloning config #1771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
danielroe
wants to merge
1
commit into
main
Choose a base branch
from
fix/runtime-config-clone
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| import { describe, expect, it } from 'vitest' | ||
| import type { Nuxt, ViteConfig } from '@nuxt/schema' | ||
|
|
||
| import { getVitestConfigFromNuxt } from '../../src/config.ts' | ||
| import { deepCopy } from '../../src/utils.ts' | ||
|
|
||
| describe('deepCopy', () => { | ||
| it('should copy through proxies', () => { | ||
| const source = new Proxy({ nested: new Proxy({ a: 1 }, {}) }, {}) | ||
| const copy = deepCopy(source) | ||
| expect(copy).toEqual({ nested: { a: 1 } }) | ||
| copy.nested.a = 2 | ||
| expect(source.nested.a).toBe(1) | ||
| }) | ||
|
|
||
| it('should preserve functions and class instances by reference', () => { | ||
| const fn = () => 'hi' | ||
| const date = new Date(0) | ||
| const copy = deepCopy({ fn, date, list: [fn] }) | ||
| expect(copy.fn).toBe(fn) | ||
| expect(copy.date).toBe(date) | ||
| expect(copy.list[0]).toBe(fn) | ||
| }) | ||
|
|
||
| it('should handle circular references', () => { | ||
| const source: Record<string, unknown> = { a: 1 } | ||
| source.self = source | ||
| const copy = deepCopy(source) | ||
| expect(copy.self).toBe(copy) | ||
| }) | ||
| }) | ||
|
|
||
| describe('getVitestConfigFromNuxt', () => { | ||
| it('should resolve a runtimeConfig containing a proxy', async () => { | ||
| const nuxt = { | ||
| options: { | ||
| appDir: process.cwd(), | ||
| modulesDir: [process.cwd()], | ||
| runtimeConfig: { | ||
| public: new Proxy({ debug: { hydration: true } }, {}), | ||
| }, | ||
| routeRules: {}, | ||
| app: {}, | ||
| build: { transpile: [] }, | ||
| }, | ||
| } as unknown as Nuxt | ||
|
|
||
| const config = await getVitestConfigFromNuxt({ | ||
| nuxt, | ||
| viteConfig: { plugins: [] } as unknown as ViteConfig, | ||
| }) | ||
|
|
||
| expect(config.test.environmentOptions!.nuxtRuntimeConfig).toEqual({ | ||
| public: { debug: { hydration: true } }, | ||
| }) | ||
| }) | ||
| }) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Preserve null prototypes and own
__proto__keys.Line 90 always creates
{}. Line 93 assigns an own__proto__key through the inherited setter. A null-prototype object therefore changes prototype, and a JSON-derived__proto__property is not copied as data.Create the target with
Object.create(proto). Iterate own keys withObject.keys. Define each property instead of assigning it.Proposed fix
🤖 Prompt for AI Agents