Merge the 2 gitsigns.nvim configs#2092
Open
oriori1703 wants to merge 1 commit into
Open
Conversation
Contributor
|
My vote is to enable the keymaps by default, but that's just me. |
Contributor
|
Note: closes #1926 |
Contributor
|
I vote enable by default. The other places in kickstart that there is commented out code, it feels much more optional or debatable. People almost certainly want these keymaps. They might want the keys to be different, which is why they can change it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it can be confusing for new users to have gitsigns configured in 2 places.
I'm still undecided if the merged config be in
init.luaorgitsigns.lua.In the latter, gitsigns would be disabled entirely by default, because everything outside of
init.luais optional and disabled by default.I'm leaning towards the former because I think it is useful to for new users to know which lines they changed (especially if they didn't mean to because they are still new to neovim).
Another option is to enable the keymaps by default, which further implies that it should be in
init.lua.Anyone has opinions on this?