Skip to content

docs(#3088): unify help generation and lint into vimdoc.sh, generation uses nvim source build to execute#3260

Merged
alex-courtis merged 4 commits into3088-gen_vimdoc-api-3231-remove-api-requiresfrom
3088-fix-and-unify-doc-generate-and-lint
Feb 3, 2026
Merged

docs(#3088): unify help generation and lint into vimdoc.sh, generation uses nvim source build to execute#3260
alex-courtis merged 4 commits into3088-gen_vimdoc-api-3231-remove-api-requiresfrom
3088-fix-and-unify-doc-generate-and-lint

Conversation

@alex-courtis
Copy link
Member

@alex-courtis alex-courtis commented Feb 3, 2026

Generate is failing for users: #3244 (comment)

Looks like I made two bad assumptions:

  • gen_vimdoc.lua runs #!/usr/bin/env -S nvim -l which is the system installed nvim, with possibly different compiled RTPs when versions are different
  • nvim 0.10 source has gen_vimdoc.lua and luacats_parser.lua in the scripts directory, which was moved to gen/src in 0.11.

After tweaking, it does run with 0.10, however the results are a bit different: looks like a couple of bugs were fixed in the generator.

Conservative fix:

  • expect v0.11 + sources
  • Don't invoke gen_vimdoc.lua directly, use the nvim make doc to execute it, using the built executable
  • Unified genation and lint into scripts/vimdoc.sh

mkdir -p "${DIR_NVIM_SRC}"
curl -L "https://github.com/neovim/neovim/archive/refs/tags/${{ matrix.nvim_version }}.tar.gz" | tar zx --directory "${DIR_NVIM_SRC}/.."
cd "${DIR_NVIM_SRC}"
make doc
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that doc is successful without our changes for easier diagnosis.


set -e

if [ $# -ne 1 ] || [ "${1}" != "doc" ] && [ "${1}" != "lintdoc" ]; then
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the nvim make targets.

@przepompownia
Copy link
Collaborator

make help-check works here for me using Nvim on the master branch.

@alex-courtis
Copy link
Member Author

make help-check works here for me using Nvim on the master branch.

Many thanks!

@alex-courtis alex-courtis changed the title docs(#3241): unify help generation and lint into vimdoc.sh, generation uses nvim source build to execute docs(#3088): unify help generation and lint into vimdoc.sh, generation uses nvim source build to execute Feb 3, 2026
@alex-courtis alex-courtis merged commit 8f30a4a into 3088-gen_vimdoc-api-3231-remove-api-requires Feb 3, 2026
5 checks passed
@alex-courtis alex-courtis deleted the 3088-fix-and-unify-doc-generate-and-lint branch February 3, 2026 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants