Enable parsing comments when using the TinyGLTF or RapidJSON loaders - #3
Merged
Merged
Conversation
Signed-off-by: Nia Bickford <nbickford@nvidia.com>
NBickford-NV
force-pushed
the
nbickford/parse-comments
branch
from
September 3, 2026 00:12
c99ce3f to
dfeae22
Compare
mklefrancois
reviewed
Sep 3, 2026
Signed-off-by: Nia Bickford <nbickford@nvidia.com>
NBickford-NV
force-pushed
the
nbickford/parse-comments
branch
from
September 3, 2026 11:53
9155fac to
74ce471
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although comments are non-standard JSON (it's often added in extensions of JSON like JSON5), there's a glTF file that exists out there that uses comments. We'd like to handle that, and thankfully this is a one-line change for each parser TinyGLTF supports.
Tiny repro case: https://gitlab-master.nvidia.com/nbickford/test-gltf-with-comments
Thanks!