Repository navigation
Resolve signer account from address - #734
Merged
Merged
Conversation
Useful especially in ROFL manifests where admin account can be named differently on each computer.
✅ Deploy Preview for oasisprotocol-cli canceled.
|
kostko
approved these changes
Oct 14, 2026
kostko
reviewed
Oct 14, 2026
| // Name may be a native or Ethereum address instead; resolve it to the matching configured | ||
| // wallet account, if any. | ||
| if addr, ethAddr, err := helpers.ResolveEthOrOasisAddress(name); err == nil && addr != nil { | ||
| for accName, acfg := range cfg.Wallet.All { |
Member
There was a problem hiding this comment.
Note that multiple accounts can resolve to the same address in which case this would be ambiguous. Currently this takes a random account while the other possibility would be to detect and reject such cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In ROFL manifests, you currently need to set the
admin:field to a valid account name in your wallet. This may differ from device to device, depending on how you named it. This PR allows you to define the signer account by its address as well and maps it to the corresponding local account name, if it exists.Can be also used in combination with
--account <name_or_address>flag for any other command.