Repository navigation
rofl: Replace expired machines still returned by the market - #736
Open
ElMagAmine wants to merge 4 commits into
Open
ElMagAmine wants to merge 4 commits into
ElMagAmine wants to merge 4 commits into
Conversation
✅ Deploy Preview for oasisprotocol-cli canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An expired machine can still be returned as accepted by the market, allowing deployment to reuse it. Check its paid period before deployment and require
--replace-machineto rent a replacement; otherwise return an expiration error. Compare Unix seconds directly to preserve future timestamps across the unsigned range. Add boundary and error-path tests and clarify the flag documentation.The regression fails on the base and passes with the change. The full Go suite passes with race detection; Go lint and build succeed. Module tidy leaves dependency files unchanged.
The regression instruments signing, broadcast and fatal-exit boundaries; end-to-end deployment, live startup and scheduler log availability remain unverified. Expiration uses the local clock; chain clock skew is not addressed.