Skip to content

fix(desktop): quit for real from the close button and the tray, add minimize to tray and keep a nick change across restarts - #320

Open
matheusfillipe wants to merge 2 commits into
fix/docs-formatfrom
fix/desktop-quit-and-nick
Open

matheusfillipe wants to merge 2 commits into
fix/docs-formatfrom
fix/desktop-quit-and-nick

Conversation

@matheusfillipe

Copy link
Copy Markdown
Contributor

On desktop the app could not be quit: the close button hid it to the tray and Quit in the tray left the process running. A nick changed in settings or with /nick went back to the old one after a restart.

  • The close button and Quit in the tray end the app. The tray menu also offers Minimize to tray and Show Obby.
  • A nick the user asks for is saved once the server confirms it. A nick the server assigns on its own (a collision or guest nick) is not.

Depends on #319, merge that first.

@coderabbitai

coderabbitai Bot commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1262445e-94fd-466d-94b4-9a4e767fdfb9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Pages Preview
Preview URL: https://fix-desktop-quit-and-nick.obsidianirc.pages.dev

Automated deployment preview for the PR in the Cloudflare Pages.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant