fix(cmake): specify project to only use c#2018
Open
kr-t wants to merge 1 commit into
Open
Conversation
This makes installing cxx compiler unnecessary Signed-off-by: Krisztian Szilvasi <34309983+kr-t@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not sure if this is a correct move, but I think it is.
While using a minimal docker image to cross-compile the project I work on (which uses libcoap), I have got a following error:
This error is raised, because the project requires CXX and C languages in Cmake. While I can workaround this without issues (by using dummy path to CXX and some additional Cmake arguments), I think the correct thing would be to remove dependency on CXX. Since cpp in the whole project is only used for zephyr test, it shouldn't affect anything. I have created before hand a fork and tested things in CI, and everything seems to work as before (why wouldn't it). Functionally, my cross-compiled application turned out fine, without needing CXX and libcoap worked as expected.
I would understand if you want to keep it as it is, but I think removing unnecessary dependencies are always a good solution. In worst case, once libcoap actually uses CXX (if ever), it can just add it back.
Feel free to close the PR without merging, if you disagree.