fix: improve e2e to not conflict when run in parallel#894
Open
JoaoBraveCoding wants to merge 2 commits intoobservatorium:mainfrom
Open
fix: improve e2e to not conflict when run in parallel#894JoaoBraveCoding wants to merge 2 commits intoobservatorium:mainfrom
JoaoBraveCoding wants to merge 2 commits intoobservatorium:mainfrom
Conversation
JoaoBraveCoding
changed the title
JoaoBraveCoding
force-pushed
the
fix-e2e-flaky
branch
from
0a14cbb to
ee36e75
Compare
Use a per-test network name derived from t.Name() with e2e.WithName, since bare e2e.New() hashes runtime.Caller(3) and collides on testing.tRunner for every test. Derive TLS/OIDC hostnames from e.Name() via getContainerName, drop fixed env name constants, and align Dex/tenant API host with the observatorium-api runnable.
JoaoBraveCoding
force-pushed
the
fix-e2e-flaky
branch
from
ee36e75 to
3d8a165
Compare
Sign leaves with the parsed CA so AuthorityKeyId matches SubjectKeyId on ca.pem. Add host.docker.internal to Dex/API SANs, set tls.ServerName to the Dex Docker hostname when posting to dex/token, and fail if ca.pem does not parse into the root pool.
JoaoBraveCoding
force-pushed
the
fix-e2e-flaky
branch
from
3d8a165 to
85627d9
Compare
JoaoBraveCoding
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve e2e tests by: