feat: support Kafka tables in TypeScript and Python schemas - #217
Merged
Merged
Conversation
Vex-Session: session-3f7b5454082bbc65a32ad720
Vex-Session: session-3f7b5454082bbc65a32ad720
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kafka queues currently require manual SQL because
table()assumes MergeTree keys and settings. This adds native Kafka schema support in TypeScript first, followed by the Python equivalent, covering the Kafka → materialized view → MergeTree pipeline.Fixes #203 (Kafka must-haves). Distributed remains a separate follow-up.
Behavior
--allow-destructivegate.kafka_auto_offset_resetexample: configureauto_offset_resetserver-side instead.Risks and boundaries
Replacing a queue interrupts ingestion and can replay or miss messages depending on consumer groups, offsets, retention, and in-flight work. There is no automatic replacement or exactly-once guarantee. Storage tables are retained in the documented workflow; operators must account for unmanaged views and other consumers. Pull warns about credential settings and rejects redacted placeholders during generation.
Validation
main, with no new errors.