Conversation
Vex-Session: session-3d2280c915ff1d225b320b01
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Collaborator
|
Addressed by #221 text-index batching/timeouts path; closing in favor of post-merge ObsessionDB CI on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The printable-escape test timed out after 15 seconds in the main-branch ObsessionDB CI job because it issued 94 sequential database requests.
Combine those checks into one
UNION ALLquery, returning each character code for per-escape assertion diagnostics. Keep the invalid hexadecimal escape assertion, add a result-count check, and retain the existing 15-second suite timeout.Validation:
bunx turbo run typecheck lint build: all 31 tasks passed.git diff --check: passed.Managed ObsessionDB validation was unavailable locally because the configured Doppler project could not be found. PR CI covers the full suite against local ClickHouse and the text-index matrix on 26.3 and 26.8.