fix: use clickhouse.cluster for async migration polling (#207) - #219
Merged
Merged
Conversation
Hardcoded clusterAllReplicas('cluster', ...) broke async mode when
clickhouse.cluster was set to a real name. Add optional
systemTableSource on ClickHouseExecutor, shared observableSystemTable
helper, and wire queryStatus + backfill syncProgress through it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #207.
Async migration polling and backfill progress reconciliation hardcoded
clusterAllReplicas('cluster', ...), so clusters configured as e.g.moebel_clusterfailed withRequested cluster 'cluster' not found.Design
systemTableSource?(table: 'processes' | 'query_log'): stringonClickHouseExecutor(not mandatory — remote/ObsessionDB executors may omit it).observableSystemTable(executor, table)helper: uses the capability when present, elsesystem.${table}.clickhouse.clusterset →clusterAllReplicas('<name>', system.${table})(name already validated atresolveConfig, same contract asonClusterClause)system.${table}(never guesses'cluster')queryStatus()(@chkit/clickhouse) andsyncProgress()(@chkit/plugin-backfill) both go throughobservableSystemTable— one owner.systemTableSourcewhen present so capability is not stripped under--debug.Literal cluster name
clusterstill works when configured as such.Test plan
@chkit/clickhouseunit tests: named cluster, no cluster (no literal'cluster'emitted),{cluster}macro, configured'cluster', capability fallback,queryStatusSQL capture@chkit/plugin-backfillsyncProgresstests: clustered capability, no-capability local fallback, undefined capability still reconcilesbun run typecheck/bun run lint/bun testfor@chkit/clickhouseand@chkit/plugin-backfillbun run typecheck/bun run lintfor@chkit/cli(debug wrapper)