-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
CI: Add Steam build uploader #6185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
96a2669 to
3173e0d
Compare
|
Updated to get a more recent 7zip from a Ubuntu PPA and replaced all the ugly temporary json files with using variables that are piped into |
|
Startled the witches of nitpick forest, but looks fine overall. Do we have to use batch scripts (i.e. prescribed by Steam)? I'd prefer Powershell, but with Windows preventing user-initiated Powershell scripts by default I wouldn't know if it works out of the box. |
|
The batch script were simply adapted from the existing virtualcam install script. Since powershell is blocked by default that probably wouldn't work, and iirc I tried running a powershell script in an earlier iteration but that didn't work for some reason (maybe steam does a bit more than just telling the OS to run a file and didn't recognise |
Yeah I'm worried that Windows will just block execution and batch scripts are just the way to go. |
39f1427 to
897f57b
Compare
RytoEX
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a quick review.
RytoEX
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine. I left a comment on the frequency of the cron timing. Approved otherwise.
|
Where does Steam install the app bundle to on macOS? Did anyone test this already? |
|
From memory it should be in |
Ugly, but should cause no issues. |
Well it did cause the issue of browser source not loading, which was fixed in 269d48f :P Fun fact: Epic puts stuff into |
3091dab to
2f5da94
Compare
|
@PatTheMav If this is still good to go, I'll land it. |
|
In the best tradition of our joint indulgence of nitpicking, I added a few picked nits of my own. |
|
@PatTheMav Re-requesting review until we get to an approval. |
Description
Adds a GitHub actions workflow as well as necessary files for Steam build to be uploaded directly from this repo.
This is version 1 of this workflow, which does not yet account for M1/Apple Silicon builds. Once we get closer to starting the beta phase of the next release and have decided on a naming scheme for builds, whether to use universal builds for Steam, etc. the action will be updated to a "v2".
Motivation and Context
OBS is now on Steam, we don't want to have to deal with manually uploading builds. As originally proposed in obsproject/rfcs#30 this adds the necessary automation via GitHub actions.
Thanks to OpenTTD whose workflow has served an inspiration for this version.
How Has This Been Tested?
A number of runs of various iterations on my own repo: https://github.com/derrod/obs-studio/actions/workflows/steam.yml
A run with the version in this PR at the time of submission is here: https://github.com/derrod/obs-studio/actions/runs/2021121357
I'm sure some people have ideas to optimise it further as I'm not exactly experienced with writing github actions.
Types of changes
Checklist: