feat(cli): add doctor integrations for first-class host status - #1314
Open
knqiufan wants to merge 3 commits into
Open
feat(cli): add doctor integrations for first-class host status#1314knqiufan wants to merge 3 commits into
knqiufan wants to merge 3 commits into
Conversation
Let users choose first-class hosts instead of PATH-scanning, and isolate one host failure from the rest.
29 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue or RFC does this PR close?
Closes #1313
Depends on #1311. Related to #1301; that issue stays with
setup select.Rationale for this change
setup selectcan install more than one first-class host, but diagnosis is still one fail-closeddoctor <host>command per integration. Concatenating those commands exits 1 on the first missing CLI, so a machine that only has Codex looks unhealthy.This PR adds a read-only overview that reports every first-class host, treats a missing CLI as
missinginstead of a command failure, and still fails when a present host is broken.What changes are included in this PR?
powercontext doctor integrations/--jsonover the shared feat(cli): add setup select for explicit multi-host plugin install #1311 catalog:codex,claude-code,dsh,pi,hermes._diagnostics_ok. Do not scan PATH to build the menu. Do not install, start the Server, or launch a host.plugin, orpackagefor Pi). Missing CLI + skipped integration →missingand does not fail the command. A present host with a failed CLI call or failed integration → exit 1.doctorstill checks only package + Server.doctor <host>remains fail-closed when that CLI is missing.setup selectis unchanged.tests/test_doctor_integrations.pycovers the five-host JSON matrix, missing-CLI success, present plugin failure, present list-call failure, all-missing success, emptydoctornot scanning hosts, anddoctor codexstill exiting 1 when Codex is missing.This branch is stacked on #1311 (
feat/cli-setup-select). Until that PR merges, the diff againstmasteralso includessetup select. The doctor-only change is commitb87faa8.Are there any user-facing changes?
Yes. New optional command:
No breaking API or storage-format change. Empty
doctoranddoctor <host>keep their current behavior.How was this change tested?
python -m pytest tests/test_doctor_integrations.pypython -m pytest tests/test_setup_select.py tests/test_system_cli.py tests/test_dsh_cli.py tests/test_hermes_cli.py tests/test_pi_cli.pyruff checkon the changed Python filesty checkon the changed Python filesAI usage statement
Used for implementation and review against the issue contract. The command surface, exit-code rules, and acceptance criteria follow #1313.