Fix unclosed file warnings

[lucduron]

No description provided.

[lucduron]

Here is a script to display warnings:

import xarray as xr

from xarray_selafin.xarray_backend import SelafinBackendEntrypoint

import warnings
warnings.simplefilter("default")

slf_in = "tests/data/r3d_tidal_flats.slf"
ds = xr.open_dataset(slf_in, engine=SelafinBackendEntrypoint)
ds.selafin.write("OUT.slf")
ds.close()

The generated output:

ResourceWarning: unclosed file <_io.BufferedWriter name='OUT.slf'>
  write_serafin(filepath, ds)
ResourceWarning: Enable tracemalloc to get the object allocation traceback
sys:1: ResourceWarning: unclosed file <_io.BufferedReader name='tests/data/r3d_tidal_flats.slf'>

It shows that without this PR, there are 2 warnings:

• on the opened file to read
• on the opened file to write

[tomsail]

this one looks good to me.
@pmav99 do you have any comments on the tests?

[tomsail]

Hi @lucduron, would you know I actually get an error now?
The only changes from your last push is the modification from your other PR

[lucduron]

Hi @tomsail, thank for you for the integration of different PRs. I had a look and it seems that my modification on write_serafin
has been overwritten by the merge, it should be fine with my last commit.

[lucduron]

@tomsail , I noticed some changes on io_test.py due to the merge (consecutive PRs with some common modifications?), can you check that it is OK?

[tomsail]

thanks @lucduron I took the wrong incoming changes when merging online.

some changes on io_test.py due to the merge (consecutive PRs with some common modifications?), can you check that it is OK?

In this PR, the only changes I see are the ones you did in commit 55beefe, which are fine for me. Did you mean more changes?

[lucduron]

Hi @tomsail, it seems OK indeed for the tests, sorry for the confusion.