Skip to content

feat!(W-24078824): remove support for installing legacy plugins #1395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WillieRuemmele merged 1 commit into from
Sep 11, 2026
+2 −35
Merged

feat!(W-24078824): remove support for installing legacy plugins #1395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions eslint-suppressions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,14 +188,8 @@
"@typescript-eslint/no-unsafe-assignment": {
"count": 1
},
"@typescript-eslint/no-unsafe-call": {
"count": 1
},
"@typescript-eslint/no-unsafe-member-access": {
"count": 1
},
"@typescript-eslint/prefer-nullish-coalescing": {
"count": 3
"count": 2
},
"@typescript-eslint/use-unknown-in-catch-callback-variable": {
"count": 1
Expand Down Expand Up @@ -322,4 +316,4 @@
"count": 1
}
}
}
}
8 changes: 0 additions & 8 deletions src/plugins.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,14 +417,6 @@ export default class Plugins {
private isValidPlugin(p: Config): boolean {
if (p.valid) return true

if (
this.config.plugins.get('@oclif/plugin-legacy') ||
// @ts-expect-error because _base is private
p._base.includes('@oclif/plugin-legacy')
) {
return true
}

throw new Errors.CLIError('plugin is invalid', {
suggestions: [
'Plugin failed to install because it does not appear to be a valid CLI plugin.\nIf you are sure it is, contact the CLI developer noting this error.',
Expand Down
19 changes: 0 additions & 19 deletions test/integration/install.integration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,23 +255,4 @@ describe('install/uninstall integration tests', () => {
expect(result?.some((r) => r.name === plugin)).to.be.false
})
})

describe('legacy plugin', () => {
it('should install legacy plugin', async () => {
await runCommand('plugins install @oclif/plugin-legacy')
await runCommand('plugins install @heroku-cli/plugin-ps-exec --silent')
const {result, stdout} = await runCommand<Array<{name: string}>>('plugins')
expect(stdout).to.contain('@heroku-cli/plugin-ps-exec')
expect(result?.some((r) => r.name === '@heroku-cli/plugin-ps-exec')).to.be.true
})

it('should uninstall legacy plugin', async () => {
await runCommand('plugins uninstall @heroku-cli/plugin-ps-exec')
await runCommand('plugins uninstall @oclif/plugin-legacy')
const {result, stdout} = await runCommand<Array<{name: string}>>('plugins')
expect(stdout).to.contain('No plugins installed.')
expect(result?.some((r) => r.name === '@heroku-cli/plugin-ps-exec')).to.be.false
expect(result?.some((r) => r.name === '@oclif/plugin-legacy')).to.be.false
})
})
})
Loading