Repository navigation
feat(scenarios): add meter-value-negative to the corpus - #189
Conversation
METER_VALUE_ANOMALY has two branches and only the decreasing one was exercised. This trace drives the register to -50 Wh, which a cumulative register can never read, so the negative check now has a regression guard. Registers in index.ts and index.test.ts, bumps the external fixture and both README counts, and adds a patch changeset.
The BootNotification CallResult sat on one line over the 100 character print width, so format:check failed before the suite ran.
|
Thank you for this, and sorry about the ten day wait, which was mine rather than anything to do with your push: GitHub holds the first workflow run from a new contributor until a maintainer releases it, and yours sat untouched showing you nothing. I have run the full check at your head commit and the only thing wrong was |
closes #182
METER_VALUE_ANOMALY has two branches and only the decreasing one was covered by the corpus, so a change that dropped the negative check would have sailed through the whole suite. This adds meter-value-negative: a cumulative register that reads -50 Wh, which physically can't happen, driving the negative branch directly.
Files: the scenario itself, registered in index.ts and asserted in index.test.ts (count, name order, getScenario, and an engine run that confirms the failure fires). The external fixture test and both READMEs bump 23 to 24. A patch changeset sits in .changeset since a new scenario does add a public export.