[IMP] sale_stock, web: update return order dialog design#4951
Merged
kcv-odoo merged 1 commit intomaster-website_sale-add-return-flow-kcvfrom Feb 4, 2026
Conversation
|
This PR targets the un-managed branch odoo-dev/odoo:master-website_sale-add-return-flow-kcv, it needs to be retargeted before it can be merged. |
ldau-odoo
force-pushed
the
master-website_sale-add-return-flow-design-ldau
branch
5 times, most recently
from
c61634f to
84690e7
Compare
kcv-odoo
force-pushed
the
master-website_sale-add-return-flow-kcv
branch
from
9e5789a to
b0f315e
Compare
ldau-odoo
force-pushed
the
master-website_sale-add-return-flow-design-ldau
branch
4 times, most recently
from
8842a04 to
42a2c93
Compare
ldau-odoo
changed the title
ldau-odoo
force-pushed
the
master-website_sale-add-return-flow-design-ldau
branch
from
42a2c93 to
2ba3206
Compare
kcv-odoo
force-pushed
the
master-website_sale-add-return-flow-kcv
branch
9 times, most recently
from
110b340 to
fcdd85e
Compare
ldau-odoo
force-pushed
the
master-website_sale-add-return-flow-design-ldau
branch
from
2ba3206 to
662380e
Compare
anso-odoo
requested changes
Jan 28, 2026
anso-odoo
left a comment
anso-odoo
left a comment
There was a problem hiding this comment.
Hello @ldau-odoo, a small first review
Thanks!
addons/sale_stock/static/src/return_order_dialog/return_order_dialog.xml
Outdated
Show resolved
Hide resolved
addons/sale_stock/static/src/return_order_dialog/return_order_dialog.xml
Outdated
Show resolved
Hide resolved
| t-out="formatCurrency( | ||
| line.price, line.currency | ||
| )" | ||
| class="return_order_dialog_price h6 d-block mb-0 mb-sm-2 text-nowrap fw-bold text-end" |
There was a problem hiding this comment.
Why not use straight <h6> tag instead of a <span> ?
Author
There was a problem hiding this comment.
I kept the span because it’s not semantically a title—we just wanted the h6 style.
addons/sale_stock/static/src/return_order_dialog/return_order_dialog.xml
Outdated
Show resolved
Hide resolved
addons/sale_stock/static/src/return_order_dialog/return_order_dialog.xml
Outdated
Show resolved
Hide resolved
addons/sale_stock/static/src/return_order_dialog/return_order_dialog.js
Outdated
Show resolved
Hide resolved
addons/sale_stock/static/src/return_order_dialog/return_order_dialog.js
Outdated
Show resolved
Hide resolved
addons/sale_stock/static/src/return_order_dialog/return_order_dialog.xml
Outdated
Show resolved
Hide resolved
ldau-odoo
force-pushed
the
master-website_sale-add-return-flow-design-ldau
branch
3 times, most recently
from
f460a4b to
f2489d3
Compare
anso-odoo
requested changes
Feb 2, 2026
anso-odoo
left a comment
anso-odoo
left a comment
There was a problem hiding this comment.
Nice @ldau-odoo !
I still have some guidelines and wording suggestions, can you check ?
addons/sale_stock/static/src/return_order_dialog/return_order_dialog.xml
Outdated
Show resolved
Hide resolved
addons/sale_stock/static/src/return_order_dialog/return_order_dialog.xml
Outdated
Show resolved
Hide resolved
addons/sale_stock/static/src/return_order_dialog/return_order_dialog.scss
Outdated
Show resolved
Hide resolved
addons/sale_stock/static/src/return_order_dialog/return_order_dialog.scss
Outdated
Show resolved
Hide resolved
addons/sale_stock/static/src/return_order_dialog/return_order_dialog.scss
Outdated
Show resolved
Hide resolved
ldau-odoo
force-pushed
the
master-website_sale-add-return-flow-design-ldau
branch
from
f2489d3 to
3573986
Compare
anso-odoo
approved these changes
Feb 3, 2026
| <div t-if="line.delivery_name"> | ||
| Delivery: <t t-out="line.delivery_name"/> | ||
| <div t-if="line.delivery_name" class="small"> | ||
| Delivery: <strong class="text-muted"><t t-out="line.delivery_name" /></strong> |
There was a problem hiding this comment.
Not sure text-muted is necessary since it's the important information
| > | ||
| Continue | ||
| </button> | ||
| <span t-if="noProductAndNoReason" class="ms-2 text-muted small">Select at least one product and a return reason.</span> |
There was a problem hiding this comment.
Suggested change
| <span t-if="noProductAndNoReason" class="ms-2 text-muted small">Select at least one product and a return reason.</span> | |
| <small t-if="noProductAndNoReason" class="ms-2 text-muted">Select at least one product and a return reason.</span> |
This commit improves the design of the return order dialog by making it more consistent with the product configuration dialog. It also introduces a new prop for the confirmation dialog to change its size, as the "sm" size may be too small for some use cases. task-5477354
ldau-odoo
force-pushed
the
master-website_sale-add-return-flow-design-ldau
branch
from
3573986 to
bc9b9f8
Compare
|
This PR targets the un-managed branch odoo-dev/odoo:master-website_sale-add-return-flow-kcv, it needs to be retargeted before it can be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the design of the return order dialog by making
it more consistent with the product configuration dialog.
It also introduces a new prop for the confirmation dialog to change
its size, as the "sm" size may be too small for some use cases.
task-5477354