[IMP] l10n_es: create new assets for es localization#4991
Open
hugocahu wants to merge 1 commit into19.0-l10n_es-accounting-onboarding-malbfrom
Open
[IMP] l10n_es: create new assets for es localization#4991hugocahu wants to merge 1 commit into19.0-l10n_es-accounting-onboarding-malbfrom
hugocahu wants to merge 1 commit into19.0-l10n_es-accounting-onboarding-malbfrom
Conversation
|
This PR targets the un-managed branch odoo-dev/odoo:19.0-l10n_es-accounting-onboarding-malb, it needs to be retargeted before it can be merged. |
malb-odoo
reviewed
Jan 27, 2026
malb-odoo
left a comment
malb-odoo
left a comment
There was a problem hiding this comment.
Almoooost good !
commit message is missing the task id and a bit of explanation though
| "account_asset_es_development","account_common_2801","account_account_es_acc_depreciation","account_account_es_680000","Development","60","1" | ||
| "account_asset_es_administrative_concessions","account_common_2802","account_account_es_acc_depreciation","account_account_es_682000","Administrative concessions","60","1" | ||
| "account_asset_es_industrial_property","account_common_2803","account_account_es_acc_depreciation","account_account_es_682000","Industrial property","120","1" | ||
| "account_asset_es_goodwill","","account_account_es_acc_depreciation","account_account_es_682000","Goodwill","120","1" |
There was a problem hiding this comment.
care that this one should be for another template 👀
malb-odoo
reviewed
Jan 28, 2026
malb-odoo
left a comment
malb-odoo
left a comment
There was a problem hiding this comment.
One small thing ! also don't forget to squash the commits, if you don't know how you have a small explanation in the Newbies FAQ 😄
| @@ -0,0 +1,2 @@ | |||
| "id","account_asset_id","account_depreciation_id","account_depreciation_expense_id","name","method_number","method_period" | |||
| "account_asset_es_goodwill","account_full_2804","2_account_common_2800","2_account_common_682","Goodwill","120","1" | |||
There was a problem hiding this comment.
I suppose you meant that 😄
Suggested change
| "account_asset_es_goodwill","account_full_2804","2_account_common_2800","2_account_common_682","Goodwill","120","1" | |
| "account_asset_es_goodwill","account_full_2804","account_common_2800","account_common_682","Goodwill","120","1" |
[IMP] l10n_es: change asset template and add correct accounts [IMP] l10n_es: create new assets for es localization
hugocahu
force-pushed
the
19.0-new_assets_model-cahu
branch
from
fafd70d to
1384410
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a new assets model for Spain and link the assets with the accounts
task-5867696