Open
Conversation
|
This PR targets the un-managed branch odoo-dev/odoo:master-hr-onboarding, it needs to be retargeted before it can be merged. |
added 2 commits
February 3, 2026 13:44
The new contract option under the hr employee payroll tab will be conditionally visible in case the employee already had a contract. Otherwise the user is not permitted to initiate a new contract without an older one Task: 5904916
…ction Steps to reproduce: 1- Setup a leave type to 'require allocation' = True. 2- Create allocations to an employee of the same leave type. 3- Create a leave from the timeoff smart button on the leave type list view. 4- Create a leave for the allocated employee and select the leave type field. 5- System throws an exception. **Issue**: Due to an error in the virtual_remaining_leaves computation function, leave types that required allocation were throwing an error to the user whenever they tried assigning time off to any employee due to a missing parameter in the method being called '_compute_virtual_remaining_leave' **Fix**: Added the value of the number of days requested for the leave in the 'is_valid' function in order to satisfy the operands requirements. Task: 5905492
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.