[FIX] hr: set new contract button invisible #5012
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:master-hr-onboarding-dianv, it needs to be retargeted before it can be merged. |
arpi-odoo
requested changes
Feb 2, 2026
arpi-odoo
left a comment
arpi-odoo
left a comment
There was a problem hiding this comment.
Code is good but this should have the tag [FIX] as it is fixing a bug. 😉
Make sure to correct that in the commit message and in the PR title.
This sets the "New Contract" button on the employee form invisible if the contract start date is not set. Task: 5900839
dianv-odoo
force-pushed
the
master-hr-onboarding-set_new_contract_button_invisible-dianv
branch
from
c340436 to
ce9d7a9
Compare
dianv-odoo
changed the title
|
This PR targets the un-managed branch odoo-dev/odoo:master-hr-onboarding-dianv, it needs to be retargeted before it can be merged. |
arpi-odoo
deleted the
master-hr-onboarding-set_new_contract_button_invisible-dianv
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets the "New Contract" button on the employee form invisible if the contract start date is not set.
Task: 5900839