-
Notifications
You must be signed in to change notification settings - Fork 10.9k
[IMP] db: odoo accounts update #15530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6d5c76e to
17ce80f
Compare
auva-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @xpl-odoo I wrote a few comments:questions 🙂
Also, just a general, probably nitpick, comment but why use bold and not guilabel for a lot of the different options?
Let me know if you'd like to discuss any of my questions!
| From the user portal, the delete option can be accessed by going to :menuselection:`My Account --> | ||
| Edit Security Settings --> Delete Account`. It can also be accessed by going to | ||
| `https://www.odoo.com/my/home <https://www.odoo.com/my/home>`_. | ||
| - Enable **two-factor authentication** using an authenticator app. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just my personal opinion but I think we could give a bit more information about the steps, like we did in the old version of this doc.
Also, should we mention Trusted devices (and how you can remove them) and the "Revoke all" button --> what does that do exactly? does it remove all trusted devices?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we have a rather in-depth documentation on 2FA (at database-level), I think a seealso could work here.
I don't see anything about Trusted devices here. Mind sharing where/how you find that? (maybe I'm just blind 😅 )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah you're right, a seealso is sufficient! As far as the trusted devices go, I think it's just because I have enabled one for my account (probably the "don't ask again on this device" option or something similar).
| .. danger:: | ||
| Deleting your Odoo.com account is **irreversible**. Once deleted, your account **cannot be | ||
| retrieved**. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and what about the Developer API key section? Should we at least refer to the documentation link provided on the page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't think dev mode would impact that page - thanks for pointing it out! After investigating, it's a relatively niche use (to download DB dumps) according to Antoine, hence why it's "hidden" under dev mode.
Still, I'll mention it and use the same link provided on the page, but I don't think it's necessary to explain further.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand because I don't think I enabled dev mode and I could still see this section? (I just tried again and was able to see it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it's visible by default for Odoo employees, but that's not the case for non-Odoo employees :)
17ce80f to
e89c2c4
Compare
auva-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the clarifications @xpl-odoo, LGTM (besides that one mystery with the dev mode)!
e89c2c4 to
e4fc19c
Compare
|
@robodoo r+ |
|
@xpl-odoo you can't review+. |
|
@robodoo r+ |
closes #15530 Signed-off-by: Audrey Vandromme (auva) <auva@odoo.com>

No description provided.