Skip to content

Conversation

@xpl-odoo
Copy link
Contributor

@xpl-odoo xpl-odoo commented Dec 1, 2025

No description provided.

@robodoo
Copy link
Collaborator

robodoo commented Dec 1, 2025

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team December 1, 2025 13:11
@xpl-odoo xpl-odoo force-pushed the 17.0-db-accounts-xpl branch 2 times, most recently from 6d5c76e to 17ce80f Compare December 1, 2025 15:38
Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @xpl-odoo I wrote a few comments:questions 🙂
Also, just a general, probably nitpick, comment but why use bold and not guilabel for a lot of the different options?

Let me know if you'd like to discuss any of my questions!

From the user portal, the delete option can be accessed by going to :menuselection:`My Account -->
Edit Security Settings --> Delete Account`. It can also be accessed by going to
`https://www.odoo.com/my/home <https://www.odoo.com/my/home>`_.
- Enable **two-factor authentication** using an authenticator app.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just my personal opinion but I think we could give a bit more information about the steps, like we did in the old version of this doc.

Also, should we mention Trusted devices (and how you can remove them) and the "Revoke all" button --> what does that do exactly? does it remove all trusted devices?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we have a rather in-depth documentation on 2FA (at database-level), I think a seealso could work here.
I don't see anything about Trusted devices here. Mind sharing where/how you find that? (maybe I'm just blind 😅 )

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah you're right, a seealso is sufficient! As far as the trusted devices go, I think it's just because I have enabled one for my account (probably the "don't ask again on this device" option or something similar).

.. danger::
Deleting your Odoo.com account is **irreversible**. Once deleted, your account **cannot be
retrieved**.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and what about the Developer API key section? Should we at least refer to the documentation link provided on the page?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't think dev mode would impact that page - thanks for pointing it out! After investigating, it's a relatively niche use (to download DB dumps) according to Antoine, hence why it's "hidden" under dev mode.
Still, I'll mention it and use the same link provided on the page, but I don't think it's necessary to explain further.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand because I don't think I enabled dev mode and I could still see this section? (I just tried again and was able to see it)

Copy link
Contributor Author

@xpl-odoo xpl-odoo Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's visible by default for Odoo employees, but that's not the case for non-Odoo employees :)

@xpl-odoo xpl-odoo force-pushed the 17.0-db-accounts-xpl branch from 17ce80f to e89c2c4 Compare December 8, 2025 18:46
@xpl-odoo xpl-odoo requested review from auva-odoo and removed request for a team December 8, 2025 19:06
Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the clarifications @xpl-odoo, LGTM (besides that one mystery with the dev mode)!

@xpl-odoo xpl-odoo force-pushed the 17.0-db-accounts-xpl branch from e89c2c4 to e4fc19c Compare December 9, 2025 13:02
@xpl-odoo
Copy link
Contributor Author

xpl-odoo commented Dec 9, 2025

@robodoo r+

@robodoo
Copy link
Collaborator

robodoo commented Dec 9, 2025

@xpl-odoo you can't review+.

@auva-odoo
Copy link
Contributor

@robodoo r+

robodoo pushed a commit that referenced this pull request Dec 9, 2025
closes #15530

Signed-off-by: Audrey Vandromme (auva) <auva@odoo.com>
@robodoo robodoo requested a deployment to merge December 9, 2025 18:07 Abandoned
@robodoo robodoo closed this Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants