Estate module declaration and models #1126
Open
+823
−186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
artn-odoo
reviewed
Jan 20, 2026
artn-odoo
left a comment
artn-odoo
left a comment
There was a problem hiding this comment.
Good job so far, just a few styling nitpicks but it's good overall !
We try to always add a newline at the end of a file. This can be done by activating the Insert Final Newline if you are using vscode.
Also, we have pretty strict guidelines regarding the commit titles and message. You can find them here for future commits https://www.odoo.com/documentation/16.0/contributing/development/git_guidelines.html
estate/__manifest__.py
Outdated
Comment on lines
3
to
12
| 'version':'1.0', | ||
| 'summary':'Track advertisements added for real estate and allow selling them', | ||
| 'website':'https://www.odoo.com/app/estate', | ||
| 'depends':[ | ||
| 'base' | ||
| ], | ||
| 'application':True, | ||
| 'installable':True, | ||
| 'author':'moali', | ||
| 'license':'LGPL-3' |
There was a problem hiding this comment.
Try to leave a white space after :
Suggested change
| 'version':'1.0', | |
| 'summary':'Track advertisements added for real estate and allow selling them', | |
| 'website':'https://www.odoo.com/app/estate', | |
| 'depends':[ | |
| 'base' | |
| ], | |
| 'application':True, | |
| 'installable':True, | |
| 'author':'moali', | |
| 'license':'LGPL-3' | |
| 'version':' 1.0', | |
| 'summary': 'Track advertisements added for real estate and allow selling them', | |
| 'website': 'https://www.odoo.com/app/estate', | |
| 'depends': [ | |
| 'base' | |
| ], | |
| 'application': True, | |
| 'installable': True, | |
| 'author': 'moali', | |
| 'license': 'LGPL-3' |
estate/models/estate_property.py
Outdated
| _name = 'estate_property' | ||
| _description = 'Estate Property' | ||
|
|
||
| name = fields.Char(string = "Property Name", required = True) |
There was a problem hiding this comment.
We try not to put white spaces around the = sign in function calls or function definitions.
The same can be said for all the fields below.
Suggested change
| name = fields.Char(string = "Property Name", required = True) | |
| name = fields.Char(string="Property Name", required=True) |
Author
|
I have created a new commit with the formatted code |
csan-odoo
requested changes
Jan 21, 2026
csan-odoo
left a comment
csan-odoo
left a comment
There was a problem hiding this comment.
Great work overall! Just a few minor adjustments needed. Also:
- When defining view names, please follow the usual Odoo convention by using dot notation (e.g., module.view_name).
- Make sure to include any unnecessary files in the .gitignore to keep the repository clean.
Thanks!
| # -*- coding: utf-8 -*- | ||
|
|
||
| from . import controllers | ||
| from . import controllers |
Estate Included related fields in order to allow the communication between the estate property base model and tags, types, offers, users, and partners model to extend the funcationalities of the current module to cater for the business need of having specific sales info. for each record
Estate Added action buttons to sell/cancel an apartment and accept or refuse a given offer. The added actions and functionalities are aiming to provide the user of the estate app with more flexible actions in order to complete their tasks of selling or cancelling real estate listings as well as accepting or refusing any given offer against that listing. Moreover, accepting an offer will automatically sell the listing to that bidder
SQL and python constraints were added to the module in order to enforce checks on the validity of selling price and uniqueness of tags and types
Added the stat_button and inline editting of lists and tags as well as improved the widgets options and visibility on the ui in order to improve the overall user experience of the estate module
…g the formatting Resolved all the comments through following the odoo convention
… under salesperson Modified the CRUD actions in order to cater for the business logic and prevent deletion of properties that has offers. Also included the properties listed under each salesperson to show the user the more information regarding their listed properties
…ties Added the estate_account module and overrided the estate_property sell method in order to automate the invoice creation process and link betweem the estate property module and the invoince module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.