Skip to content

Conversation

@WaleedElgamal
Copy link

No description provided.

@robodoo
Copy link

robodoo commented Jan 19, 2026

Pull request status dashboard

Copy link

@artn-odoo artn-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start !
Try to always add a description to describe your commit as it will make it easier for others to understand what you did.

Storing informtion related to properties in the module which will be mapped by ORM to a database table
Defining the access rights to the 'property' model
Define the author and license in manifest file
@artn-odoo artn-odoo requested a review from csan-odoo January 21, 2026 08:56
Created three menus which are linked to a a single action which creates a new property
Create custom search, list and form views for the properties with filter and group by options
Copy link

@csan-odoo csan-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Just a few minor nitpicks

Created new models including property types, tags and offers. Linked the property to these models and added buyer info
Compute total living area and offer deadline. Also autofill fields when garden is selected
Added buttons to mark a property listing as sold/cancel, as well as buttons to accept or reject an offer
Added sql constraints to prevent negative values and python constraints to offer price
Copy link

@csan-odoo csan-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Just a couple of small nitpicks. Big props to the Gree Runbot!

Added validation in the property form for a more consistent app. Linked different views together for better accessibility. Added some improvements in terms of search, filter and visibilty.
Remove redundant search and form views and fix import formatting
Override CRUD methods to delete a property in certain states only and to update property state on offer creation with same or higher value offers.

Link properties in res.users model by inheritance to display them in list view under the salesperson profile.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants