Consume the dead-code gate from ops instead of vendoring it - #26
Merged
Conversation
…b4jfhz) This repo was missed by 86cb417ty, which removed the vendored copy from six repos. There were nine. This one still carried the pre-fix script at blob 117e0e5 — no `command -v vulture` guard, so with vulture absent it printed "no dead code found" and exited 0 having checked nothing. Not currently biting in CI, which installs vulture explicitly, but live for any local run and for a silently failed install step. ruff-config is deliberately not added: this repo's shared ruff standard lives in ruff.toml and check-ruff-config.py reads pyproject.toml only. Tracked as 86cb4jfzk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of 86cb4jfhz.
This repo was missed
86cb417ty fixed the fail-open dead-code gate and deleted the vendored copies — from six repos. There were nine. That ticket said the script was vendored "in at least six repos" and listed six; the list was verified exhaustively and the hedge was read past.
This repo still carried the pre-fix script at blob
117e0e5e, byte-identical to the buggy version:With
vultureabsent fromPATH, command-not-found goes to/dev/null,|| truediscards exit 127, and the gate reports a clean scan having checked nothing.Not currently biting in CI —
lint.ymlinstallsvulture==2.14explicitly, so the gate does run. But the fail-open behaviour is live for any local invocation, and for a silently failed install step.What changed
The vendored copy is deleted; the gate now comes from
offworldlabs/opspinned athooks-v1.0, the same way the other six repos consume it.pre-commit==4.6.2joins the existing pinned install line, andvulture==2.14stays on it — thedead-codehook islanguage: script, so pre-commit builds no environment and vulture must be onPATH.Deliberately not included
The
ruff-confighook. This repo's shared ruff standard lives inruff.toml, andcheck-ruff-config.pycurrently readspyproject.tomlonly — it exits 2 here. The standard is present and matches canonical exactly, but it is unenforced. Tracked as 86cb4jfzk.Verification
pre-commit run --all-files→dead code (vulture)....PassedPATH, the hook exits 127 withcheck-dead-code: vulture is not installed or not on PATH. Previously that same input printedno dead code foundand exited 0.🤖 Generated with Claude Code
https://claude.ai/code/session_013ZcazeseXVpu8XrYA2tE1V