20260813 - Bump config-merger pin to v0.4.3.0 - #28
Merged
Conversation
The pin had been frozen at v0.3.17 since release v0.4.0, so every
config-merger change since has been built and published by CI but never
deployed. scripts/build_mender_artifact.sh sed-strips ${VAR:-default}
down to the default literal, so the shipped artifact uses whatever this
line says - and nothing sets CONFIG_MERGER_V.
Two changes were stranded on every fielded node:
- generate_retina_tracker_config (1936173) - wires retina-tracker's
min_snr, so the GUI's Minimum SNR field has never reached the
tracker; nodes silently run the image default or a stale
retina-tracker.yaml instead
- migrate_gain_reduction (e96c56d) - the scalar to per-tuner
gainReduction migration
Confirmed absent from the running v0.3.17 image on both Jonathan nodes.
v0.4.3.0 is the newest published merger image and contains both.
Symptom fix only: the pin is still a manual step that must be bumped
every release. It should be derived from the release version instead,
since the merger image is always published under that exact tag.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CONFIG_MERGER_Vhas defaulted tov0.3.17since release v0.4.0 — six releases ago — while every other image pin moved on. Becausescripts/build_mender_artifact.shsed-strips${VAR:-default}down to the default literal, that default is exactly what ships to devices. It is not a fallback; it is the shipped value.CI has built and published a fresh merger image on every release the whole time (
retina-config-merger:v0.4.3.0exists in ghcr right now). Nothing consumed any of them, so nothing appeared broken.v0.3.17also isn't a tag in this repo — tags jump v0.3.16 → v0.4.0 — so the pinned image came from a manualworkflow_dispatchbuild and maps to no commit.Impact
Verified by extracting the files from the
v0.3.17image running on both Jonathan nodes and diffing againstmain. Five merged changes have never reached a node:Script (both functions absent from the deployed image):
generate_retina_tracker_config(1936173) — writesretina-tracker.yaml. Without it the GUI's Minimum SNR field is a silent no-op: nodes fall back to the tracker image's own default, or keep a staleretina-tracker.yamlforever.migrate_gain_reduction(e96c56d) — scalar →[reference, surveillance]migration.Baked-in
config/default.yml(the image bakes this in too):gainReduction: 40→[40, 40](653d305)process.tracker.enable: true→false(46f7bc2)retina_tracker: min_snr: 7.0section (1936173)Per-tuner gain is therefore stranded twice over: nodes still carry the scalar default and lack the migration that would repair it.
Change
One line — bump the default to
v0.4.3.0, the newest published merger image, which contains all of the above.Note for the next release
This pin is only ever correct for one release. The merger image is published under the retina-node release tag, so
CONFIG_MERGER_Vmust be bumped to the version being cut, in the same commit as the other five pins.v0.4.3.0here drains the backlog; it does not make the pin permanently correct.🤖 Generated with Claude Code