Document and verify authored fork delta - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
.envWhy
The fork contains meaningful authored work, but its README did not clearly separate that work from the upstream project. Its containers also depended on floating base images and checked-in local credentials, and no workflow verified the contributed delta.
Impact
Recruiters and maintainers can now see exactly what the fork demonstrates. Local secrets stay outside Git, Java and PostgreSQL versions are deterministic, and every change is verified in CI against a live database.
Validation
./mvnw --batch-mode --no-transfer-progress verifyinmaven:3.9-eclipse-temurin-17with PostgreSQL 16: passeddocker-compose --env-file .env.example config --quiet: passeddocker build --tag library-app-spring-boot:portfolio-check .: passed/v3/api-docsreturned a 9,834-byte OpenAPI documentgit diff --check: passed