feat: Add crashpad support#2
Draft
LukasKastern wants to merge 1 commit into
Draft
Conversation
Author
|
Making this a draft since I have a few PRs pending that I'd like to have merged first to avoid creating a bunch of dependencies on my personal forks: [ ] allyourcodebase/googletest#6 |
Owner
|
hey @LukasKastern |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change integrates crashpad into sentry native.
I also upgraded to zig 0.16.0 in the process.
I added a new example under
examples/crashpadfor testing the integration.I also added curl as an explicit dependency. The curl branch is using my boringssl fork.
If I remember correctly this was a requirement for me personally since I've used boringssl in other projects.
But it should not be a hard requirement. Meaning we probably should just let the user decide the ssl implementation and pass it downwards.