fix: make model_info optional in ShowResponse for cloud models#638
Open
Pawansingh3889 wants to merge 1 commit intoollama:mainfrom
Open
fix: make model_info optional in ShowResponse for cloud models#638Pawansingh3889 wants to merge 1 commit intoollama:mainfrom
Pawansingh3889 wants to merge 1 commit intoollama:mainfrom
Conversation
Author
|
Hi, this is a one-line fix for issue #607 — cloud models that omit model_info cause a ValidationError. Tested both cases (with and without model_info). Let me know if any changes are needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #607.
Problem
Some cloud models (e.g. glm-4.7:cloud, qwen3-next:80b-cloud, deepseek-v3.2:cloud) return /api/show responses that omit the model_info field entirely. The ShowResponse Pydantic model has model_info typed as Optional but uses Field(alias=...) without a default value, which makes Pydantic treat it as required:
Fix
One-line change in _types.py:
Adding default=None makes Pydantic respect the Optional type hint when the field is missing from the API response.
Testing
Verified both cases: