fix: make model_info optional in ShowResponse for cloud model compatibility#648
Open
CyberRaccoonTeam wants to merge 1 commit intoollama:mainfrom
Open
Conversation
…bility Pydantic requires explicit default=None for Optional fields with aliases. Without it, ShowResponse raises ValidationError when /api/show omits model_info, which happens with some cloud models. Fixes ollama#607
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ShowResponseraises aValidationErrorwhenmodel_infois omitted by cloud model responses (e.g., when using OpenAI-compatible endpoints through Ollama).Problem
Cloud models and some local models do not return
model_infoin their response, causing a validation error instead of gracefully handling the missing field.Solution
Make
model_infooptional with a default ofNonein theShowResponsemodel.Testing
model_infomodel_infoFixes the issue where
client.show()crashes on cloud model responses.