feat: add stack history, rollback, and history-values commands#37
Merged
feat: add stack history, rollback, and history-values commands#37
Conversation
Add CLI commands for deployment history (with pagination), one-click rollback, and viewing historical deploy values. Updates DeploymentLog type to include values snapshot and target log fields, and adds corresponding client SDK methods. Companion to k8s-stack-manager#114. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
Author
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
- Add --quiet support to stackHistoryValuesCmd (prints log ID only)
- Replace anonymous struct in RollbackStack with named RollbackResponse type
- Fix GetStackLogs to decode DeploymentLogResult (matches backend pagination)
- Change DeployLogValuesResponse.Values from interface{} to map[string]interface{}
- Add 6 client tests, 8 command tests, and integration test for rollback flow
- Update existing test mocks to return DeploymentLogResult wrapper
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stack historycommand with pagination support for deployment historystack rollbackcommand with--yesconfirmation skip and--target-logtargetingstack history-valuescommand to view values from a past deploymentDeploymentLogtype (removesBaseembed, adds explicit fields includingValuesSnapshotandTargetLogID)GetDeploymentHistory(),RollbackStack(), andGetDeployLogValues()client SDK methodsCompanion to omattsson/k8s-stack-manager#114.
Test plan
go test ./...)stack history <id>returns paginated deployment logsstack rollback <id>with and without--yesflagstack history-values <id> <log-id>returns values snapshot🤖 Generated with Claude Code