Conversation
Override set was sending values as a JSON map but the backend expects a YAML string. Changed SetValueOverrideRequest.Values to string and added yaml.Marshal serialization before sending. (Closes #45) Added cluster shared-values list/set/delete commands so cluster-level Helm values can be configured once instead of per-instance. (Closes #47) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
override setwas sending values as a JSON map ({"values": {"key": "val"}}) but the backend expects a YAML string ({"values": "key: val"}). ChangedSetValueOverrideRequest.Valuestostringand addedyaml.Marshalserialization before sending.cluster shared-values list/set/deletecommands so cluster-level Helm values can be configured once instead of repeated per-instance per-chart overrides. Supports--file,--set,--name, and--priorityflags.Changes
pkg/types/types.go:SetValueOverrideRequest.Valueschanged frommap[string]interface{}tostring; addedSharedValuesandSetSharedValuesRequesttypescmd/override.go: Addedyaml.Marshal(values)before sending requestpkg/client/client.go: AddedListSharedValues,SetSharedValues,DeleteSharedValuesmethodscmd/cluster.go: Addedcluster shared-values list/set/deletecommandsTest plan
go test ./... -count=1— all packages passgo vet ./...— cleanstackctl override setandstackctl cluster shared-values set🤖 Generated with Claude Code