Skip to content

fix: override set YAML format + cluster shared-values commands#52

Merged
omattsson merged 1 commit intomainfrom
feat/override-values-format-cluster-shared-values
Apr 22, 2026
Merged

fix: override set YAML format + cluster shared-values commands#52
omattsson merged 1 commit intomainfrom
feat/override-values-format-cluster-shared-values

Conversation

@omattsson
Copy link
Copy Markdown
Owner

Summary

Changes

  • pkg/types/types.go: SetValueOverrideRequest.Values changed from map[string]interface{} to string; added SharedValues and SetSharedValuesRequest types
  • cmd/override.go: Added yaml.Marshal(values) before sending request
  • pkg/client/client.go: Added ListSharedValues, SetSharedValues, DeleteSharedValues methods
  • cmd/cluster.go: Added cluster shared-values list/set/delete commands
  • Updated all tests (unit, client, integration, live) for the new string type
  • Added 16 command tests and 8 client tests for shared-values
  • README updated with new commands and corrected override quota flags

Test plan

  • go test ./... -count=1 — all packages pass
  • go vet ./... — clean
  • Override set tests validate YAML string in request body
  • Shared-values tests cover table/JSON/YAML/quiet output, file/set input, path traversal, confirmation flow, error handling
  • Manual test against running backend with stackctl override set and stackctl cluster shared-values set

🤖 Generated with Claude Code

Override set was sending values as a JSON map but the backend expects a
YAML string. Changed SetValueOverrideRequest.Values to string and added
yaml.Marshal serialization before sending. (Closes #45)

Added cluster shared-values list/set/delete commands so cluster-level
Helm values can be configured once instead of per-instance. (Closes #47)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@omattsson omattsson merged commit 197be6c into main Apr 22, 2026
6 checks passed
@omattsson omattsson deleted the feat/override-values-format-cluster-shared-values branch April 22, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reduce per-instance override burden for local dev clusters override set: CLI sends JSON map but backend expects YAML string

1 participant