fix(paseo-omp): preserve Windows process tree during cleanup - #152
Merged
Merged
Conversation
omercnet
force-pushed
the
fix/windows-process-cleanup-order
branch
from
September 22, 2026 20:46
700d824 to
5627692
Compare
omercnet
force-pushed
the
fix/windows-process-cleanup-order
branch
from
September 23, 2026 07:34
5627692 to
6902f23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Windows shutdown started
taskkill /T /Fand immediately sent stdin EOF. A leader that exits on EOF can disappear beforetaskkilldiscovers its ignored-stdio descendant, leaving that descendant orphaned.TDD regression
The first commit is the real Windows leader-plus-ignored-stdio-descendant reproduction from #151. It requires
session.close()to leave no descendant alive. The second commit fixes that failing behavior.Change
Verification
npx vitest run tests/omp-rpc-process.test.ts tests/mcp-transport.test.tsnpm run typechecknpm run checknpm test