Skip to content

test(paseo-omp): cover OMP cancellation outcomes - #155

Merged
omercnet merged 1 commit into
mainfrom
fix/paseo-omp-cancellation-followup
Sep 23, 2026
Merged

omercnet merged 1 commit into
mainfrom
fix/paseo-omp-cancellation-followup

Conversation

@omercnet

Copy link
Copy Markdown
Owner

Summary

  • add observable provider regressions: native abort with error text produces exactly one canceled turn, genuine native failure remains failed, and later turns complete
  • record #5101, #4921, and merged #5243 (90737e1) in the existing core-provider audit row
  • document that detached-child Stop behavior remains intentionally unchanged pending product direction in Should foreground Stop preserve detached OMP child sessions? getpaseo/paseo#5256

Deliberate non-change

Parent cancellation continues to terminalize all subsessions. Preserving only detached child descriptors is unsafe while shared host-tool cleanup can abort the child’s in-flight work.

Verification

  • npm test -- tests/provider-interrupt.test.ts — 17 passed
  • npm run typecheck
  • npm run check

Copilot AI lite review requested due to automatic review settings September 23, 2026 09:56

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@omercnet
omercnet merged commit 691dd28 into main Sep 23, 2026
18 checks passed
@omercnet
omercnet deleted the fix/paseo-omp-cancellation-followup branch September 23, 2026 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants