Skip to content

fix: progress bar visibility, title spacing, and import/export button…#369

Merged
omeritzics merged 2 commits into
mainfrom
new-main
Jun 9, 2026
Merged

fix: progress bar visibility, title spacing, and import/export button…#369
omeritzics merged 2 commits into
mainfrom
new-main

Conversation

@omeritzics

@omeritzics omeritzics commented Jun 9, 2026

Copy link
Copy Markdown
Owner

… scope

Summary by CodeRabbit

  • Documentation

    • Improved formatting and clarity of migration instructions in README.
  • UI Changes

    • Removed import/export button from add-app confirmation screen.
    • Progress indicator now displays only while actively searching.

@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

The PR removes import/export functionality from the add_app page by deleting the associated FloatingActionButton and its animation dependency, makes the progress indicator display conditional based on active search state, and reformats migration documentation with clearer step formatting and a modernized arrow symbol.

Changes

Add App Page Refactoring

Layer / File(s) Summary
Remove import/export button and clean up imports
lib/pages/add_app.dart
The import/export FloatingActionButton is removed from the confirmation screen; animations and import_export_page imports are deleted since they are no longer needed.
Conditionally render progress indicator
lib/pages/add_app.dart
The SliverAppBar progress bar now only displays when actively searching or picking app sources, improving layout when no operation is in progress.

Documentation Updates

Layer / File(s) Summary
Reformat migration instructions
README.md
"On Obtainium" and "On Updatium" migration steps are reorganized into a clearer ordered list with the import/export arrow formatted as "→" instead of "->".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🐰 A button hops away, animations too,
Progress bars now peek when there's work to do,
Docs get arrow charm, → gleams so bright,
Fewer dependencies make the code just right! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes: removing the import/export button from add_app.dart, fixing progress bar visibility with conditional rendering, and adjusting title spacing/padding.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch new-main

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the README.md to use arrow symbols instead of hyphens and greater-than signs. In add_app.dart, it removes unused imports, conditionally displays the AppAddingProgressBar in the SliverAppBar based on search and source selection states, and removes the Import/Export floating action button from the confirmation page. There are no review comments, so no additional feedback is provided.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@omeritzics omeritzics merged commit 7670b43 into main Jun 9, 2026
9 of 11 checks passed
@omeritzics omeritzics deleted the new-main branch June 9, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant