Added network retries option

[ajzkk]

Purpose

Added network retries option

Example Usage

var omise = require('omise')({
  ...
  maxNetworkRetries : 2
});

Checklist

• I have applied development best practices
• I am following the change management guidelines
• If my change require, I have updated the documentation accordingly. [PCI DSS 6.5.6]
• The default rollback procedure can be used. [PCI DSS 6.5.5.4]
• All relevant quality testing is being done. [PCI DSS 6.4.5.3]
• The correct people are assigned to review the pull request. [PCI DSS 6.4.5.2]
• There is no business impact planned. [PCI DSS 6.4.5.1]
• The correct labels such as minor, medium, major have been added.
• If this is a significant change, security team have reviewed the change. [PCI DSS 6.4.6]
• No manual Pre or Post deployment steps needed.

[danfowler]

Which error cases does this cover?

[ajzkk]

• Network-related errors
• Connection errors
• HTTP protocol errors and
• Server errors(status code in the range of 500-599)

[danfowler]

Can you point me to the docs?

[ajzkk]

https://nodejs.org/api/http.html#http_http_request_options_callback

[aashishgurung]

Our APIs handles 500 and 503 errors and responds a JSON. Will this cover those cases as well?

https://www.omise.co/api-errors#500-internal-server-error

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

No Coverage information
0.0% Duplication