Repository navigation
fix(wic): orphan warnings in initramfs ext4 fsck invocations on ro partitions - #701
Conversation
When in testing a wic image is used multiple times to initialize a test device it can happen that a stale journal i.e., one from system runs prior to flashing anew, gets applied. This can happen when ... - bmaptool is used to flash scarce wic images - the wic images don't populate the journal data region This fix stops using the lazy journal initialization so that the journal data gets part of the generated wic image, even though large parts of them are filled with `0` (and would therefore be left out normally). Signed-off-by: Harry Waschkeit <44188360+HarryWaschkeit@users.noreply.github.com>
HarryWaschkeit
changed the title
JanZachmann
left a comment
JanZachmann
left a comment
There was a problem hiding this comment.
The approach works: with lazy_journal_init=0 the journal becomes part of the bmap, so any bmap-based flash overwrites the old journal. Two things before merge, see inline: the extra options replace wic's defaults (the inode count on data halves), and the result depends on FIEMAP on the build host.
Description: "scarce wic images" should be "sparse". Removing the journal from the read-only partitions is a separate change and could be its own commit.
21eca0a to
5c721b6
Compare
…pts` Signed-off-by: Harry Waschkeit <44188360+HarryWaschkeit@users.noreply.github.com>
…initramfs fsck output Signed-off-by: Harry Waschkeit <44188360+HarryWaschkeit@users.noreply.github.com>
HarryWaschkeit
changed the title
HarryWaschkeit
changed the title
JanZachmann
left a comment
JanZachmann
left a comment
There was a problem hiding this comment.
The PR title and description become the squash commit, and both describe the cause wrongly. The initramfs runs no fsck on rootA/rootB/factory (check_fs only runs for cert, etc, data and boot). EXT4-fs (...): orphan cleanup on readonly fs is a kernel info message at mount time: with the orphan_file feature, which the mke2fs.conf of the build enables by default, the kernel prints it on every read-only mount, also when there is no orphan. So nothing is found and nothing is left unfixed. The change removes that feature, together with the journal. Could you reword title and description along these lines? The fix(wic) scope will also be too narrow once the ext4 image gets the same options (see the rootB thread).
…ages Signed-off-by: Harry Waschkeit <44188360+HarryWaschkeit@users.noreply.github.com>
When read-only partitions get mounted during system start-up there are always orphan entries found that cannot be fixed.
Turning off journaling on read-only partition - which doesn't make sense anyway -, gets rid of these warnings..