You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This release adds TempPath::try_from_path and deprecates TempPath::from_path.
Prior to this release, TempPath::from_path made no attempts to convert relative paths into absolute paths. The following code would have deleted the wrong file:
let tmp_path = TempPath::from_path("foo")
std::env::set_current_dir("/some/other/path").unwrap();drop(tmp_path);
Now:
TempPath::from_path will attempt to convert relative paths into absolute paths. However, this isn't always possible as we need to call std::env::current_dir, which can fail. If we fail to convert the relative path to an absolute path, we simply keep the relative path.
The TempPath::try_from_path behaves exactly like TempPath::from_path, except that it returns an error if we fail to convert a relative path into an absolute path (or if the passed path is empty).
Neither function attempt to verify the existence of the file in question.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:
any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually
The artifact failure details are included below:
File name: Cargo.lock
Command failed: cargo update --config net.git-fetch-with-cli=true --manifest-path Cargo.toml --package tempfile@3.25.0 --precise 3.27.0
error: failed to load source for dependency `agent-core`
Caused by:
Unable to update /tmp/renovate/repos/agent-core
Caused by:
failed to read `/tmp/renovate/repos/agent-core/Cargo.toml`
Caused by:
No such file or directory (os error 2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
3.25.0→3.27.0Release Notes
Stebalien/tempfile (tempfile)
v3.27.0Compare Source
This release adds
TempPath::try_from_pathand deprecatesTempPath::from_path.Prior to this release,
TempPath::from_pathmade no attempts to convert relative paths into absolute paths. The following code would have deleted the wrong file:Now:
TempPath::from_pathwill attempt to convert relative paths into absolute paths. However, this isn't always possible as we need to callstd::env::current_dir, which can fail. If we fail to convert the relative path to an absolute path, we simply keep the relative path.TempPath::try_from_pathbehaves exactly likeTempPath::from_path, except that it returns an error if we fail to convert a relative path into an absolute path (or if the passed path is empty).Neither function attempt to verify the existence of the file in question.
Thanks to @meng-xu-cs for reporting this issue.
v3.26.0NamedTempFile::persiston RedoxOS (#393) (thanks to @Andy-Python-Programmer).Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.