GeoLine triangle-strip mesh render#77
Conversation
🦋 Changeset detectedLatest commit: bd8e104 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nickw1
changed the title
commit: |
|
Cool perf idea. Let me test this out a bit more, I think it could be beneficial to completely improve |
Remove separate CompositeGeoLine component. Triangle-strip mesh rendering is now built into GeoLine, with Line2 fallback for dashing.
Use BufferGeometry with indexed triangles for smoother, artifact-free line rendering. Falls back to Line2 when dashing is enabled. Widen color prop to accept ColorRepresentation.
|
Love the triangle-mesh approach for render optimization. I integrated the work directly into When I pushed these changes to your branch, give this a look and let me know Thank you for the great baseline |
|
@coopbri sounds good, will test later and let you know. |
|
@coopbri seems to work fine. |
coopbri
changed the title
GeoLine triangle-strip mesh render
|
Live in v0.10.0. Thanks! |
2 participants
Description
A new
CompositeGeoLinecomponent has been added, with similar functionality toGeoLine. However it is a mesh made up of individual triangles, meaning smoother lines with less rendering artefacts thanGeoLine, at the expense of dashed lines not being possible.It could either exist alongside
GeoLineor replace it, particularly if further enhancements to allow dashing are added (nb: I am unlikely to do this myself, at least for now).Test Steps
Run the geolocation demo. Working on a desktop with fake location set, or a mobile device with mock GPS location (signal poor indoors).