Conversation
There was a problem hiding this comment.
Pull request overview
Restores the macOS “persistent-install” integration gate in the GitHub Actions Integration workflow so hosted macOS runs no longer silently downgrade to runtime-only coverage, and updates project docs/changelog to reflect the restored gate.
Changes:
- Re-enable
--persistent-installfor the macOS Integration job matrix entry. - Update maintaining/backlog docs to reflect the restored macOS integration gate and close the corresponding backlog item.
- Add a Changie unreleased fragment noting the fix.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/MAINTAINING.md | Updates the integration test documentation to state that hosted macOS runs the persistent-install gate (and should fail clearly at the Docker Desktop boundary when applicable). |
| docs/BACKLOG.md | Removes the completed P0 backlog item about restoring hosted macOS persistent-install CI behavior. |
| .github/workflows/integration.yml | Switches macOS integration to run the persistent-install gate (via nox -s cli-integration -- --persistent-install). |
| .changes/unreleased/+macos-persistent-install-ci.yaml | Adds a release-note fragment describing the restored macOS persistent-install CI gate. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
39
to
+41
| - name: macOS amd64 | ||
| runner: ${{ inputs.macos_runner || 'macos-15-intel' }} | ||
| # GitHub-hosted macOS runners use Colima, which provides a Linux | ||
| # Docker engine. Reploy's Docker-managed permanent install support | ||
| # on macOS is intentionally Docker Desktop-only, so this hosted | ||
| # gate validates the macOS staging/runtime path without claiming | ||
| # Docker Desktop install coverage. | ||
| persistent_install: false | ||
| persistent_install: true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.