Open
Conversation
Owner
|
Wow. I don't follow the dev cycle of amazonka, but I have a few projects that use that; that's going to be fun :( I think I'd probably keep it open, until amazonka is released on hackage. Could you ping me when this happens? To be honest, I don't use this library anymore, I switched the app to sql.. any interest into becoming a maintainer? :) |
Collaborator
Author
|
I don't think I can in good conscience agree to becoming sole maintainer, but since my work uses this library I'd be okay with being a co-maintainer. Seems like there isn't much issue volume with the library, so that's good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR updates the repo to be compatible with the current
developbranch of amazonka. Amazonka has not been getting releases to hackage with any kind of regularity so at my job we've moved to tracking the develop branch. Because your project is released to hackage you might decide that you only want to target the hackage 1.6.1 version which was released in February 2019, in which case feel free to close this MR or keep it open until amazonka gets a release.There's a lot of diff here but here's a summary of the changes to amazonka off the top of my head:
sendtakes the env value directly. So your APIs that hit AWS now take an additional argument.new, e.g.putItembecomesnewPutItemputItem_) instead of a cryptic abbreviation.Textand what were previously sum type constructors are view patterns. I had to add a custom sum typeScalarValueTypefor the GADTScalarValuebecause you can't use view patterns as type parameters for GADTs. The functionality should be equivalent though.[a]are nowMaybe [a]. So you'll see a lot offromMaybe memptythat smooths over this.I also added stack files to make it a bit easier to test reproducibly but feel free to remove that.
I've merged this branch into a large project that uses
dynamodb-simpleand so far everything seems to be working.