Fixed package visibility logic and enhance target version resolution - #379
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces changes to how package versions are resolved and displayed, particularly concerning prerelease versions. The main update is to make the inclusion of prerelease versions explicit and configurable when determining the target version for package updates. Additionally, the visibility logic for featured packages has been simplified.
Key changes:
Package version resolution:
ResolveTargetVersionmethod inPackageStateExtensionsnow accepts an explicitincludePrereleaseparameter (defaulting tofalse), instead of inferring it from the installed version. This change centralizes and clarifies how prerelease versions are handled when determining which version to install.UpdateStatusmethod inPackageServicenow explicitly requests prerelease versions by passingtruetoResolveTargetVersion, ensuring that prerelease versions are considered during package status updates.UI logic simplification:
IsVisibleproperty inFeaturedPackageViewModelno longer treatsUpdateAvailablePrereleaseas a visible status, simplifying the logic for when a featured package should be shown.