Skip to content

fix: seed phrase key store type - #84

Merged
jaymengxy merged 1 commit into
mainfrom
fix-provider-wallet
Mar 5, 2026
Merged

jaymengxy merged 1 commit into
mainfrom
fix-provider-wallet

Conversation

@jaymengxy

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Mar 5, 2026 •

Copy link
Copy Markdown

PR Summary

Refactored the createKeyData() method in SeedPhraseKey class to use a proper KeyData data class instead of a generic Map for storing seed phrase information. This change improves type safety and code maintainability by replacing the map-based approach with a structured data class that explicitly defines the required fields: mnemonic, passphrase, path, and length.

Changes

File Summary
Android/wallet/src/main/java/com/flow/wallet/keys/SeedPhraseKey.kt Refactored createKeyData() method to use KeyData data class instead of generic Map<String, Any> for storing seed phrase parameters (mnemonic, passphrase, path, length), improving type safety and code structure.

autogenerated by presubmit.ai

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 Pull request needs attention.

Review Summary

Commits Considered (1)
  • 336b08c: fix: seed phrase key store type
Files Processed (1)
  • Android/wallet/src/main/java/com/flow/wallet/keys/SeedPhraseKey.kt (1 hunk)
Actionable Comments (1)
  • Android/wallet/src/main/java/com/flow/wallet/keys/SeedPhraseKey.kt [289-294]

    possible issue: "Verify KeyData class has proper serialization annotations."

Skipped Comments (0)

Comment thread Android/wallet/src/main/java/com/flow/wallet/keys/SeedPhraseKey.kt
@jaymengxy
jaymengxy merged commit 4a9cc9c into main Mar 5, 2026
1 of 2 checks passed
@jaymengxy
jaymengxy deleted the fix-provider-wallet branch March 5, 2026 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant